2009/8/21 Alessandro Diaferia <alediafe...@gmail.com> > > > 2009/8/21 Giulio Camuffo <giuliocamu...@gmail.com> > >> >> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: >> > > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, >> line 106 >> > > < >> http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file10433line106> >> > > >> > > consider deleting white spaces >> > > >> >> eh, the problem with white spaces is that they are... white :p they >> escape! > > That's why reviewboard shows them :p > >> >> >> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: >> > > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, >> line 335 >> > > < >> http://reviewboard.kde.org/r/1370/diff/3/?file=10434#file10434line335> >> > > >> > > No need for this anymore: i've committed a fixed for the bug and >> closed it. >> >> whooo! great! thanks > > =) no problem > > >> >> >> >> - Giulio >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/1370/#review2112 >> ----------------------------------------------------------- >> >> >> On 2009-08-21 14:05:09, Giulio Camuffo wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > http://reviewboard.kde.org/r/1370/ >> > ----------------------------------------------------------- >> > >> > (Updated 2009-08-21 14:05:09) >> > >> > >> > Review request for Plasma. >> > >> > >> > Summary >> > ------- >> > >> > This is a patch that modifies quite heavily the behaviour of the Device >> Notifier. >> > It comes from here: >> http://kde-look.org/content/show.php/Device+Manager?content=106051 >> > It can show the not removable devices too, it can mount them >> automatically or with a click, since the "eject" button is a "mount" button >> when the volume is umounted. So that guy on the dot will be ok. >> > It can hide some items in the same way as Dolphin's places (hide item/ >> show all). >> > Finally, it shows the various opening actions under the device instead >> of calling that xp-ish window. >> > >> > >> > Diffs >> > ----- >> > >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui >> PRE-CREATION >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h >> 1013960 >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp >> 1013960 >> > >> > Diff: http://reviewboard.kde.org/r/1370/diff >> > >> > >> > Testing >> > ------- >> > >> > I'm using it every day since I released 0.1 on Kde-look. I tried all the >> options on my pc and they work. Some people on kde-look posted some comments >> about some problems, but it seems to me they are very particular cases, so >> in my opinion it is quite stable to go in trunk, but anyway review it! :) >> > >> > >> > Screenshots >> > ----------- >> > >> > screen >> > http://reviewboard.kde.org/r/1370/s/183/ >> > >> > >> > Thanks, >> > >> > Giulio >> > >> > >> >> > > > -- > Alessandro Diaferia > KDE Developer >
Oh one last thing that comes to my mind is that the configuration dialog does not follow GUI usability guidelines. But that shouldn't be a problem, there can be a patch for it later :) -- Alessandro Diaferia KDE Developer
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
