----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1699/#review2433 -----------------------------------------------------------
i'm going to concentrate on the GlobalContext class mostly here. as it stands, GlobalContext seems like an activity manager; where "activity" is defined as "a named object stored in nepomuk". is that correct? if so, then it's not really a global Context object. perhaps an ActivityManager? or a ContextManager? it doesn't include location information either, which Plasma::Context should at some point here. GlobalContext public API may only need to be: a signal noting when the active global context changes; a way to list available activities (mostly because the method in Plasma::Context isn't static) ... /trunk/KDE/kdelibs/plasma/containment.cpp <http://reviewboard.kde.org/r/1699/#comment1737> kDebug? :) /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1738> ensureActivityExists? or maybe ensureActivity and createActivity could be merged? maybe something like: activityId(const QString &name, const QString &expectedId = QString());? or perhaps these can remain as they are but be private API? it should only really be needed by Context when setting the current activity in that Context? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1753> or perhaps: forActivity(id)->setActiveContext(true);? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1739> is this equivalent to currentContext()->name()? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1740> i'd personally expect these as static methods in Plasma::Context, e.g.: Plasma::Context::contextForActivity(QString) Plasma::Context::activeContext() /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1749> is this equivalent to: forActivity(id)->name(); ? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1747> maybe this could emit a Context object instead of a QString id? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1741> wouldn't this create an activity and associate it with this Context? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1742> setCurrentActivityId()? and then there could be a corresponding activityId(). - Aaron On 2009-09-23 20:19:36, Ivan Cukic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1699/ > ----------------------------------------------------------- > > (Updated 2009-09-23 20:19:36) > > > Review request for Plasma. > > > Summary > ------- > > Nepomuk-based storage of plasma activities > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137 > /trunk/KDE/kdelibs/plasma/applet.cpp 1027137 > /trunk/KDE/kdelibs/plasma/containment.h 1027137 > /trunk/KDE/kdelibs/plasma/containment.cpp 1027137 > /trunk/KDE/kdelibs/plasma/context.h 1027137 > /trunk/KDE/kdelibs/plasma/context.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp > PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1699/diff > > > Testing > ------- > > Needs more testing > > > Thanks, > > Ivan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel