----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1699/#review2435 -----------------------------------------------------------
I don't think I really grok what "global" is. the current desktop? the current screen? with multiple screens and/or different activities on different virtual desktops, we can have more than one plasma activity visible at once... how does that relate to nepomuk activities? /trunk/KDE/kdelibs/plasma/containment.h <http://reviewboard.kde.org/r/1699/#comment1744> s/activity/activityId to be extra clear. I don't like how "activity" sometimes means the name and sometimes the ID. /trunk/KDE/kdelibs/plasma/containment.h <http://reviewboard.kde.org/r/1699/#comment1745> does this return the id or the name? and why's there no function to set just the name? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1756> add a comment saying this class is @since 4.4 /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1751> the function name could be better. maybe just activity. and what does it do if an activity with that id and a different name exists? /trunk/KDE/kdelibs/plasma/context.h <http://reviewboard.kde.org/r/1699/#comment1754> don't start function names with "for". either activityContext or contextForActivity /trunk/KDE/kdelibs/plasma/context.cpp <http://reviewboard.kde.org/r/1699/#comment1757> oi! we use kDebug around here :) /trunk/KDE/kdelibs/plasma/context.cpp <http://reviewboard.kde.org/r/1699/#comment1758> so if nepomuk crashes and restarts itself, I have to restart plasma? plasma should watch for nepomuk appearing and disappearing. /trunk/KDE/kdelibs/plasma/context.cpp <http://reviewboard.kde.org/r/1699/#comment1759> you set realID to one thing, then another. skip this unnecessary assignment. /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp <http://reviewboard.kde.org/r/1699/#comment1760> use kDebug - Chani On 2009-09-23 20:19:36, Ivan Cukic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1699/ > ----------------------------------------------------------- > > (Updated 2009-09-23 20:19:36) > > > Review request for Plasma. > > > Summary > ------- > > Nepomuk-based storage of plasma activities > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137 > /trunk/KDE/kdelibs/plasma/applet.cpp 1027137 > /trunk/KDE/kdelibs/plasma/containment.h 1027137 > /trunk/KDE/kdelibs/plasma/containment.cpp 1027137 > /trunk/KDE/kdelibs/plasma/context.h 1027137 > /trunk/KDE/kdelibs/plasma/context.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp > PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1699/diff > > > Testing > ------- > > Needs more testing > > > Thanks, > > Ivan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel