zzag added inline comments.
INLINE COMMENTS
> extended_process_list.cpp:31
> +
> +class ExtendedProcesses::Private
> +{
Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN.
> process_data_provider.h:42-52
> + /**
> + * Accessors for process information matching
> + */
> + KSysGuard::Processes* processes() const;
> +
> + /**
> + * Returns a new process object for a given PID
Coding style inconsistency: pointer alignment.
Such inconsistency can be noticed in other parts of this patch too, e.g.
QVector<KSysGuard::ProcessAttribute*> and QVector<KSysGuard::ProcessAttribute
*>, etc.
REPOSITORY
R111 KSysguard Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23287
To: davidedmundson, #plasma, ahiemstra
Cc: zzag, ahiemstra, alexde, broulik, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
