ngraham added inline comments. INLINE COMMENTS
> zzag wrote in main.qml:300 > Qt documentation says that we need to override valueFromText > > > Note: When applying a custom textFromValue implementation for editable > > spinboxes, a matching valueFromText implementation must be provided to be > > able to convert the custom text back to an integer value. > > https://doc.qt.io/qt-5/qml-qtquick-controls2-spinbox.html#valueFromText-prop Ah ok, will add that in a follow-up patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24813 To: ngraham, #vdg, #plasma, davidedmundson Cc: zzag, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
