ndavis added a comment.
Currently, this makes text on light colorschemes that use a light Selection Text color difficult to read. To fix that and keep this look, one of these things will need to happen: -Change the colorschemes to use dark Selection Text on light themes. For colorschemes intended to be used with a Kvantum theme (Arc, Adapta), this isn't such a problem, but it's still less than ideal and it'll be really unpleasant for users of those colorschemes. - Adapt the colors created in the code to combinations of colors in the colorscheme. This could get messy and partially turns the colorscheme into a problem to solve instead of just a way to define a set of colors. - Add More colorscheme colors. We already have a lot of these and we don't make good use of all of them. - Use existing colorscheme colors in ways that don't reflect their names/descriptions. For instance, using Focus for the background of the focus effect and hover for the outline or vice versa. This makes it less clear which colorscheme colors affect what things. This is probably not everything, just what I've thought of. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
