ervin added a comment.

  In D24916#553919 <https://phabricator.kde.org/D24916#553919>, @broulik wrote:
  
  > > AFAICT it won't be pretty though. :-)
  >
  > I think it's pretty straightforward
  >  1.) the delegate must not explicitly set a `currentIndex` because Qt does 
it for us, see D18299 <https://phabricator.kde.org/D18299>
  >  2.) the wheel handler must be changed to call `decrementCurrentIndex()` 
and `incrementCurrentIndex()` (hopefully they wrap...) instead of changing the 
index manually, so it doesn't break the binding.
  
  
  Ah somehow I thought we had a third more "clever" case of currentIndex 
moving. Then indeed if that's just those two we should be fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24916

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to