ervin added a comment.

  Style wise, functions come before children objects. Other than that looks 
good to me.
  
  Through Kai comments, the question also becomes, wouldn't it be better to fix 
the root cause? It's likely we'll encounter that ComboBox breakage at other 
places.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24916

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to