apol added a comment.

  Looks good to me overall. It's better to use dbus.

INLINE COMMENTS

> org.kde.KWin.Session.xml:7
> +            <!-- set state. One of: normal, saving, quitting -->
> +            <arg name="state" type="s" direction="in"/>
> +    </method>

Here it recommends using uint for such things:
https://dbus.freedesktop.org/doc/dbus-api-design.html#interface-files

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24945

To: davidedmundson, #kwin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to