davidedmundson added inline comments. INLINE COMMENTS
> davidedmundson wrote in org.kde.KWin.Session.xml:7 > It also advocates for use of {sv} in your spec which is inherently string > based. > > I'm happy to use ints, as long as we then don't get into that trap of saying; > "now we have an enum to sync in two places, we must create a header file and > a dependency " There was a third option I considered. Have N methods startSave startQuit saveCancelled and then make the state change an implicit part of the invokable action we need to do on save. I went this way as I felt it was nice to have this acting more like a property independently, but what do you think. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24945 To: davidedmundson, #kwin Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart