ngraham created this revision. ngraham added reviewers: Kirigami, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY Right now, if you define `topContent` for your GlobalDrawer, it's added to the scrollview so it can actually scroll out of sight, making it not always on top. This patch moves the `topContent` above the scrollview so it always stays on top/ TEST PLAN Discover's GlobalDrawer toolbar no longer strangely scrolls out of view: F7680325: topContent always on top.png <https://phabricator.kde.org/F7680325> No regressions in Discover when the view is not scrollable No regressions that I could detect in Kirigami Gallery, though this probably needs lots more testing to ensure that nothing has exploded BUG: 389533 FIXED-IN: 5.64 REPOSITORY R169 Kirigami BRANCH topContent-always-on-top (branched from master) REVISION DETAIL https://phabricator.kde.org/D25019 AFFECTED FILES src/controls/GlobalDrawer.qml To: ngraham, #kirigami, mart, apol Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein