davidedmundson added inline comments.

INLINE COMMENTS

> GlobalDrawer.qml:258
> +            //as items are added only after this column creation
> +            Layout.minimumWidth: parent.width
> +            visible: children.length > 0 && childrenRect.height > 0 && 
> opacity > 0

General rule of thumb:

- implicit size goes up from children to parent (including 
Layout.min/max/preferred)

- current size goes downwards from parent to child

If you ever mix them you're asking for recursive loops.
I suspect it's the cause of the problem we're hitting.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25019

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

Reply via email to