broulik created this revision. broulik added reviewers: Plasma, bcooksley, fvogt, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY When configured to detect captive portals, NetworkManager prompts the user to log in by opening http://networkcheck.kde.org A captive portal will redirect the user and once logged in, redirect somewhere else or back to networkcheck. Currently, it doesn't automatically detect the fact that the user is now logged in and only notices after like 10 minutes. With this patch, when a new tab is opened pointing to KDE networkcheck, whenever the tab completes a navigation, (after a short delay) NetworkManager is asked to re-check network connectivity to update network connectivity basically immediately once connected. When user is then redirected back to KDE networkcheck, which just returns "OK\n", the tab is closed to not leave the user sitting at this empty OK page. TEST PLAN - Setup my NM to use networkcheck.kde.org, connected to a wifi with captive portal, clicked "Log in" on the "you need to login" prompt, my browser opened, I agreed to terms, hit "Connect", got redirected to some welcome page - With this patch the exclamation mark on the icon goes away almost immediately after connecting - Previously it would stay there pretty much forever REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D25466 AFFECTED FILES extension/_locales/en/messages.json extension/constants.js extension/extension-captiveportal.js extension/manifest.json extension/options.html host/CMakeLists.txt host/captiveportalplugin.cpp host/captiveportalplugin.h host/main.cpp To: broulik, #plasma, bcooksley, fvogt, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
