fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  IMO this should be addressed outside of PBI instead:
  
  - If a captive portal is detected, call `CheckConnectivity` with a higher 
frequency (I've never had any issues with this, actually)
  - Instead of opening `networkcheck.kde.org` in the browser when clicking the 
"Log In" button, open a page which just closes itself

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25466

To: broulik, #plasma, bcooksley, fvogt, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to