ndavis added a comment.

  Ok, so there is an overlap problem, but it's quite rare. It happens when an 
icon uses 100% of the available space in the bottom right corner (or left with 
RTL, I think).
  Here I changed the stop icon in KDevelop to the icon for Codelite: F7817068: 
Screenshot_20191213_171219.png <https://phabricator.kde.org/F7817068>.
  
  I could get around this in a number of ways that all have their downsides:
  
  - Move the arrow to the very bottom right and make sure it's small enough 
that no clipping happens
    - This looks bad and makes it harder to see the arrow
  - Reduce the default icon size for flat buttons
    - This is more consistent with non-flat buttons, but I like the bigger 
icons. They're more readable too.
  - Increase the padding around buttons
    - I like the current padding around toolbuttons
  - Ignore the problem
    - Will look fine with most icon themes, but bad in some cases such as the 
one described above.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

Reply via email to