ndavis added a comment.
In D19890#577221 <https://phabricator.kde.org/D19890#577221>, @hpereiradacosta wrote: > Confused about 2: I thought icon size was the same for flat and non flat toolbuttons (see oxygen-demo5, buttons tab) Most normal buttons use 16px icons while flat buttons on the toolbar use 22px icons. F7817118: Screenshot_20191213_175032.png <https://phabricator.kde.org/F7817118>F7817120: Screenshot_20191213_175119.png <https://phabricator.kde.org/F7817120> Here's what it looks like when flat buttons and normal buttons are both using 22px icons. F7817116: Screenshot_20191213_174918.png <https://phabricator.kde.org/F7817116> > About 3: really I think that would be bad I also think that it would cause more trouble than it would fix. > I too think that either 4 (ignoring the problem) or 5: don't change the current code, and dont revert the revert, is the way to go. > for 4: only a few icons would be affected, and only for toolbuttons with long popup delay (the only case for which this arrow is drawn). Are you saying not to revert the revert at all and instead write a new patch or is that just part of #5 (not changing the code)? > These are already rather rare, and considered bad UI anyway if I remember right. Correct, I personally think we should never use long popup delay buttons for devices with touchpads or mice. > Please pretty please, do not (re) add this arrow (whether tiny or large) to instant-popup toolbuttons though. Ok REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts, ndavis Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart
