----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3505/ -----------------------------------------------------------
(Updated 2010-04-06 19:45:35.640069) Review request for Plasma, Aaron Seigo and Marco Martin. Changes ------- Implement the suggested change by Aaron. I had to make the destructor of Task protected in order to be able to call destructors of the derived classes. Summary ------- Try to make dbus and fdo tasks have the same life cycle. Now the Manager class is responsible for calling deleteLater. Make DBus tasks emits only once the destroyed signal. Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 1111824 Diff: http://reviewboard.kde.org/r/3505/diff Testing ------- Tested with dbus and fdo tasks inside a kde 4.4.2 session and Qt 4.6.2. Nothing crash. Thanks, Matthieu _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
