----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3505/ -----------------------------------------------------------
(Updated 2010-04-06 20:13:24.362369) Review request for Plasma, Aaron Seigo and Marco Martin. Changes ------- More complete patch than the previous one. Change all the code including plasmoid protocol to use the new slot destroy in Task class. I tested the addition and removal of fdo visible and hidden tasks. I tested the addition and removal of dbus visible and hidden tasks. My testing does not trigger any problem. Summary ------- Try to make dbus and fdo tasks have the same life cycle. Now the Manager class is responsible for calling deleteLater. Make DBus tasks emits only once the destroyed signal. Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.h 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 1111824 /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol.cpp 1111824 Diff: http://reviewboard.kde.org/r/3505/diff Testing ------- Tested with dbus and fdo tasks inside a kde 4.4.2 session and Qt 4.6.2. Nothing crash. Thanks, Matthieu _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
