leinir planned changes to this revision. leinir added a comment.
In D26544#592285 <https://phabricator.kde.org/D26544#592285>, @ngraham wrote: > This patch makes plasma-desktop fail to build without the dependent KNS framework change. That means that the KNS change is in fact a hard dependency and therefore this functionality can't make it into 5.18 with the patch's current state. If you want it for 5.18 (as I assume you do, and I do too!), you'll need to make D26543 <https://phabricator.kde.org/D26543> not a dependency by only conditionally using the `KNSCore::EntryWrapper` functionality, or by finding a way to implement the fix in way that doesn't add new classes that have to be used here. ah, d'oh, yes, you're quite right... it /is/ a hard dependency, i entirely forgot about that one... not entirely sure how i forgot about it, perhaps repression from having to write it at all, but yes. Right, let's see what we can do about that, then :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
