ngraham added inline comments. INLINE COMMENTS
> colors.cpp:128 > > - const auto newEntries = m_newStuffDialog->installedEntries(); > - // If one new theme was installed, select the first color file > in it > - if (newEntries.count() == 1) { > - QStringList installedThemes; > +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MINOR>=67 > + // If one new theme was installed, select the first color file in it This wraps a lot of existing functionality into that conditional as well. Was all of that stuff broken and useless without D26543 <https://phabricator.kde.org/D26543>? Everything seems to work anyway, but I'm curious to know if everything here needs to be wrapped up in this. > kcmcursortheme.cpp:433 > { > - KNS3::DownloadDialog dialog("xcursor.knsrc", nullptr); > - if (dialog.exec()) { > - KNS3::Entry::List list = dialog.changedEntries(); > - if (!list.isEmpty()) { > - for (const KNS3::Entry& entry : list) { > - if (entry.status() == KNS3::Entry::Deleted) { > - for (const QString& deleted : entry.uninstalledFiles()) { > - QVector<QStringRef> list = > deleted.splitRef(QLatin1Char('/')); > - if (list.last() == QLatin1Char('*')) { > - list.takeLast(); > - } > - QModelIndex idx = > m_themeModel->findIndex(list.last().toString()); > - if (idx.isValid()) { > - m_themeModel->removeTheme(idx); > - } > +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MINOR>=67 > + for (int i = 0; i < changedEntries.count(); ++i) { ditto REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart