romangg requested changes to this revision. romangg added a reviewer: Plasma. romangg added a comment. This revision now requires changes to proceed.
Nice. Let's fix these few issues and get it merged before tomorrow. Other small issues can be fixed in beta phase. INLINE COMMENTS > main.qml:182 > + id: iconItem > + Layout.fillHeight: true > + implicitWidth: parent.height It works for me if you keep it `height: parent.height`. > main.qml:183 > + Layout.fillHeight: true > + implicitWidth: parent.height > + icon: model.icon This must be `width: parent.height`. implicitWidth is a read-only property. WIthout this change the qml file won't load. > main.qml:230 > + > + > + // This doesn't work, nor does keyboard input work on any other > tabbox skin (KDE 5.7.4) trailing white space REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26681 To: Zren, romangg, #plasma Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
