romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > Zren wrote in main.qml:183 > Uhg, I was using `width: parent.height` and `height: parent.height` but > changed it when cleaning it up. I must've not staged all the changes before > diffing. This has made me notice another bug though. > > By using `height: parent.height`, I was basically setting it at `height: 22`, > which is smaller than the "close button" which is 30x30. > > width: parent.height > height: parent.height > > F7884740: 2020-01-15___12-05-59.png <https://phabricator.kde.org/F7884740> > > Layout.fillHeight: true > Layout.minimumWidth: height > Layout.maximumWidth: Layout.minimumWidth > > This makes the icon slightly larger than I'm used to. > F7884741: 2020-01-15___12-04-32.png <https://phabricator.kde.org/F7884741> > > I've also noticed why I added `clip: true` to the `KWin.ThumbnailItem`, > apparently the close button is 30x30, which is taller than the > `captionRow.height: 22`. Here's a look at the overflow after removing `clip: > true` and `clipTo: parent`: > Outlines with: `Rectangle { anchors.fill: parent; border.color: "#f00"; > border.width: 1; color: "transparent" }` > F7884784: 2020-01-15___12-31-12.png <https://phabricator.kde.org/F7884784> > > I've fixed it all in the latest diff: > F7884833: 2020-01-15___12-38-31.png <https://phabricator.kde.org/F7884833> > F7884834: 2020-01-15___12-55-01.png <https://phabricator.kde.org/F7884834> Yea, just tested it again and looks good! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26681 To: Zren, romangg, #plasma Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
