meven added inline comments. INLINE COMMENTS
> bport wrote in DeviceAutomounterKCM.cpp:84 > We can also change kcfgc to add parent in constructor It would imply make AutomounterSettings not-static. I would need to change the DeviceModel that uses AutomounterSettings static functions as well. > ervin wrote in DeviceAutomounterKCM.cpp:57 > Missing this as parent, this is leaked. Also I'd likely move that in the ctor > initialization list (same thing for m_devices actually, maybe in another > patch, your call). I removed the m_settings instead, relying solely on the singleton. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27127 To: meven, ervin, ngraham, #plasma, bport, crossi Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
