ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounterKCM.cpp:57
> I removed the m_settings instead, relying solely on the singleton.

I tend to consider this as a step back to be honest. Singletons tend to be more 
trouble down the line when something goes wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to