alex added a comment.

  In D27166#617379 <https://phabricator.kde.org/D27166#617379>, @sitter wrote:
  
  > Yeah, I don't think I understand. I am sure a unit test would make things 
clearer ;) ;)
  
  
  Yes, I will add one :-).
  And in the last commit I just used a regex feature which matches all currency 
symbols, this makes it a lot easier.
  
  And a qick question: Should the converter be able to convert values like 
`US$`, If yes I would try to implement this.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to