broulik added inline comments. INLINE COMMENTS
> converterrunner.cpp:74 > + const QString valueGroup = > QStringLiteral("(?P<%1>[0-9,./]+)").arg(valueKey); > + const QString unitGroups = > QStringLiteral("(?P<%1>[a-zA-Z/\"'^0-9\\p{Sc}²³]+)"); > + const QString sourceUnitGroup = unitGroups.arg(sourceUnitKey); There's also units with µ, Ω, . (fl.oz.), not taking into account how those might be localized, so using a very specific regexp looks somewhat brittle to me. Can't really think of a better way, though... > converterrunner.cpp:129 > + if (outputUnit.categoryId() == KUnitConversion::CurrencyCategory) { > + outputValue.round(2); > } I thought `KUnitConversion` was doing that when requesting a pretty string REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart