bport added inline comments.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:88
> Are you sure this is necessary? I'd expect KCModule::load() to call load() on 
> m_skeleton

no load only do findItem for managed widget on the skeleton

> ervin wrote in spellcheckingskeleton.cpp:51
> I have a doubt, is it really necessary? I'd expect it to work without that 
> line.

Yes is necessary no code is run after that so nobody will take care of saving 
this skeleton.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to