bport added inline comments. INLINE COMMENTS
> ervin wrote in spellchecking.cpp:88 > Sure but still, the skeleton is expected to be already be in a "loaded" state > at that point, that's why it works for the items (otherwise a findItem > wouldn't be enough, it'd have to call readConfig on them or load on the whole > skeleton, and it doesn't). I think the problem is more that in the ctor of > the skeleton you initialize the items just fine but you don't initialize the > extra properties you need a call to usrRead() at the end of that ctor. Yes, or I can probably also use item like before, and that will be handled for me > ervin wrote in spellchecking.cpp:118 > I'd expect this to be the same block than the one in load() now. Since > `KCModule::defaults()` will reset the skeleton to defaults, ignoreList, > preferredLanguages and defaultLanguage will hold the default values. no because we hold loaded data if we do that, apply button will be deactivated after clicking default REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 To: bport, #plasma, meven, crossi, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
