jgrulich added a comment.
In D27764#621204 <https://phabricator.kde.org/D27764#621204>, @dkosovic wrote: > In D27764#621173 <https://phabricator.kde.org/D27764#621173>, @jgrulich wrote: > > > @dkosovic will you update the review to address my comments? > > > I agree with all your comments and they are great nitpicks and suggestions. > > Sorry I didn't have time tonight to work on testing everything and submitting an updated patch. I'm guessing submitting an updated patch is what I need to do for the review? No problem, take your time. I don't know the way you submitted this change, whether you used **arc** to do so or you just uploaded a patch. With **arc** you just create another commit and run again: arc diff If you uploaded just a patch, then I guess you will need to update it the same way. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
