ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!
  
  I'd still prefer if main.qml used Layouts instead of Anchors, I also still 
think the option to show a generic icon is not really very useful; I have a 
hard time envisioning a user who manually sets icons for their activities but 
prefers to show a generic icon in the pager. However I don't use activities and 
it's your code, so your call. :)

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to