ngraham requested changes to this revision. ngraham added a reviewer: mart. ngraham added a comment. This revision now requires changes to proceed.
I have some UI suggestions: - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add Setting button, which is a rather jargony, programmer-centric way of presenting the feature. - For consistency, use the typical way of assigning actions to Kirigami SwipeListItems, rather than implementing custom button appearance and behavior. If you did this because the Kirigami SwipeListItem has no provision to display an inline action with text as well as an icon, let's change the component to support that. - Instead of having the list item expand when clicked to reveal whether it's included or excluded, display that information in textual form in the same line, and no need to repeat the same path. This would optionally allow you to remove the magnifying glass and minus sign icons. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
