ahiemstra added inline comments.

INLINE COMMENTS

> CMakeLists.txt:44
>  
> +configure_file(krunner.service.cmake 
> ${CMAKE_CURRENT_BINARY_DIR}/krunner.service @ONLY)
> +install( FILES  ${CMAKE_CURRENT_BINARY_DIR}/krunner.service DESTINATION

This pattern is repeated multiple times, maybe we should make a macro out of 
it? Like `install_systemd_service_file(source_file)`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to