hchain added inline comments.

INLINE COMMENTS

> apol wrote in plasmawayland-dev.desktop.cmake:2
> Is this change related?

does that still work in legacy (non-systemd) mode ?

> apol wrote in org.kde.plasmashell.desktop.cmake:55
> We probably want it always hidden?

maybe add a comment that this file is superseded in systemd-mode by a custom 
service and we don't want the systemd generator to make another one for us

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

Reply via email to