broulik added a comment.

  +1

INLINE COMMENTS

> CMakeLists.txt:85
>                        )
> +find_package(KF5ActivitiesStats ${KF5_MIN_VERSION})
> +set_package_properties(KF5ActivitiesStats PROPERTIES DESCRIPTION " querying 
> of activity history"

Do we not have this dep in p-w these days already through kicker backend?

> recentdocuments.cpp:130
> +
> +    if (url.isLocalFile() && !QFileInfo(url.toLocalFile()).isDir()) {
>          actions << action(s_openParentDirId);

Why not for dirs? If you have a recent docs on a defunct network share it would 
block now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to