broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:13
> KF5::I18n
> + KF5::Activities
> + KF5::ActivitiesStats
Where's this being used? I only see stats
> recentdocuments.cpp:78
>
> - const QUrl url = QUrl(config.readUrl());
> - if (knownUrls.contains(url)) {
> - continue;
> - }
> + const auto url = QUrl::fromUserInput(result->data(index,
> ResultModel::ResourceRole).toString());
> + const auto name = result->data(index,
> ResultModel::TitleRole).toString();
Do we really want `QUrl::fromUserInput` here? This thing typically assumes web
addresses. Maybe pass `AssumeLocalFile`? But I recal that doing a file system
access every time checking for existance.. probably not a big deal in this
instance since it's in a thread
> recentdocuments.cpp:88
> + match.setType(Plasma::QueryMatch::ExactMatch);
> + } else if(url.fileName().startsWith(term)) {
> + relevance = 0.9;
Coding style
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D26111_1
REVISION DETAIL
https://phabricator.kde.org/D26111
To: meven, #plasma, ivan, ngraham, broulik
Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
