niccolove added inline comments.

INLINE COMMENTS

> broulik wrote in NotificationItem.qml:125
> Please use one of the `State` below for `inGroup` state

I originally did this but I had a problem. It displays and works just as good, 
but it will throw a "you are using anchors in layouts" error in the console. 
Even though I disable the anchors in the propertychanges, it seems like the 
property is updated after throwing the error.

> broulik wrote in NotificationItem.qml:139
> This `MouseArea` should not be necessary and it makes the close button 
> unusable

Why shouldn't it be necessary?  PlasmoidHeading inherits from the Control 
element, which does not let click events through according to the 
documentation, so I thought I'd need to catch them on top of it.

Regarding the close button unusable, it's due to the order of the elements, 
I'll fix it immediately

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to