broulik added inline comments.
INLINE COMMENTS
> NotificationItem.qml:116
> + Layout.fillWidth: true
> + implicitHeight: !notificationItem.inGroup ?
> notificationHeading.implicitHeight : 0
> +
When `inGroup` the height will be zero so you effectively leak the item
contents outside? I don't get what this is supposed to do.
> NotificationItem.qml:128
>
> - inGroup: notificationItem.inGroup
> + RowLayout {
> + anchors.fill: parent
This item is pointless since there's only the `NotificationHeader` inside
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29234
To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
