broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> NotificationItem.qml:118
> + Layout.preferredWidth: notificationHeading.implicitWidth
> + id: headingElement
> +
Put `id` at the top
> NotificationItem.qml:122
> + imagePath: "widgets/plasmoidheading"
> + prefix: 'header'
> + anchors.fill: parent
Use `"`
> NotificationItem.qml:123
> + prefix: 'header'
> + anchors.fill: parent
> + anchors.topMargin: -margins.top
You can group those
anchors {
fill: parent
topMargin: ...
...
}
> NotificationItem.qml:173
> Layout.preferredHeight: implicitHeight
> + Layout.fillWidth: true
> textFormat: Text.PlainText
Keep it where it was
REPOSITORY
R120 Plasma Workspace
BRANCH
fix_notifications (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29234
To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
