ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks like this code has changed a bit between 5.18 and 5.19. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart