> On 2010-09-01 16:42:41, Martin Gräßlin wrote: > > To be honest I do not see the usefulness of such an effect :-) > > > > If I understand your code correctly you are creating four GL Textures for > > the corners. That are three too many. Mirroring textures is very easy in > > OpenGL. In general I would prefer if such eyecandy stuff only uses GLSL > > (which raises the requirements to OpenGL 2). So you would just specify one > > VBO and use vertex attributes to indicate the corner and do the mirroring > > in the fragment shader. This would also add the possibility to easily do > > nice radiant fade outs, so that only the pixel nearest to the corner is > > black while the other parts are translucent. > > > > It would be nice if you could attach a screenshot and please get feedback > > from Oxygen (designers) and please add Plasma to the groups as well. This > > is heavily influencing the look of the Plasma Workspace, so they should > > also have their say on it. > > > > Oh and please have a look on the HACKING file in kwin source directory for > > coding style. > > Christoph Feck wrote: > As far as I understand it, this should not be enabled as default, but > only enable eye candy to all those that want emulate Mac designs (and I can > already see all the screen shots posted to sites everywhere, where this > "effect" is enabled). > > Cannot comment on the technical side, but smooth anti-aliasing is a MUST > (standard OpenGL anti-aliasing probably is too coarse).
Thanks a lot for reviews and comments. Can't upload a screenshot in this reviewboard here: [Errno 13] Permission denied: '/var/www/sites/svn.reviewboard.kde.org/htdocs/media/uploaded/images/2010/09/02' So I added one to this place: http://img842.imageshack.us/img842/6695/withdarkgreyborder.jpg (with a dark grey frame to simulate a monitor and to get a better impression) plasma-group is added. As I can see from http://www.oxygen-icons.org/?page_id=16 Thomas Lübking is already from the Oxygen-Team. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5225/#review7350 ----------------------------------------------------------- On 2010-09-02 10:01:55, Christoph Fritz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5225/ > ----------------------------------------------------------- > > (Updated 2010-09-02 10:01:55) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Summary > ------- > > Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes > corners of the desktop rounded. > Older Macs and Monitors had this feature too. > > > Diffs > ----- > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170001 > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop > PRE-CREATION > > tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui > PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/5225/diff > > > Testing > ------- > > > Thanks, > > Christoph > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
