----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9214 -----------------------------------------------------------
A few remarks after a quick look: - you should not leave the debug output, too much noise for reading the diff, please remove and repost new diff - you should not modify indentation - > correct in new diff - the Phonon headers do not need to be included twice - where is the pig.wav from? It should be installed and read from global installation with KStandardDirs. And the name should be changed! - Anne-Marie On 2010-12-12 19:20:12, Sunny Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6108/ > ----------------------------------------------------------- > > (Updated 2010-12-12 19:20:12) > > > Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. > > > Summary > ------- > > Hello Everybody, > > i have implemented the chiming of the analog clock every hour.though i have > hard coded it and it would only chime every hour. and not for 45 mins. > Presently I am working on the development of a ui which would allow the user > to set the clock to chime according to the choice of the user. > > thanks, > sunny_slls > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt > 1203585 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h > 1203585 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp > 1203585 > > Diff: http://svn.reviewboard.kde.org/r/6108/diff > > > Testing > ------- > > > Thanks, > > Sunny > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
