----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9223 -----------------------------------------------------------
as others noted, the debug should be removed for the final patch; but we're not quite there yet :) this code really belongs, as John Layt noted, in libplasmaclock. in kdebase/workspace/libs/plasmaclock/clockapplet.cpp there is a updateClockApplet method that now calls speakTime. this feature should be handled similarly, perhaps with a chimeTime() method. /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt <http://svn.reviewboard.kde.org/r/6108/#comment10094> shouldn't be in the final patch :) /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp <http://svn.reviewboard.kde.org/r/6108/#comment10095> whitespace: } else { - Aaron On 2010-12-12 23:01:41, Sunny Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6108/ > ----------------------------------------------------------- > > (Updated 2010-12-12 23:01:41) > > > Review request for Plasma and Anne-Marie Mahfouf. > > > Summary > ------- > > Hello Everybody, > > i have implemented the chiming of the analog clock every hour.though i have > hard coded it and it would only chime every hour. and not for 45 mins. > Presently I am working on the development of a ui which would allow the user > to set the clock to chime according to the choice of the user. > > thanks, > sunny_slls > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt > 1203585 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h > 1203585 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp > 1203585 > > Diff: http://svn.reviewboard.kde.org/r/6108/diff > > > Testing > ------- > > > Thanks, > > Sunny > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel