----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/#review2950 -----------------------------------------------------------
an interesting idea, but the configuration values should not appear in the metadata.desktop file. it not only bloats up the # of keys we have, it doesn't scale to plasmoids with more/different configuration. i think this would make more sense as a .desktop + a KConfigGroup (could even be in the same file?) that holds the complete default configuration that is then copied over after the applet is created. - Aaron J. On April 28, 2011, 8:30 p.m., David Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101251/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 8:30 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > There is some code duplication in that some plasmoids share very much of > program logic but actually differ in just a setting. E.g. the recently made > ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon > plasmoid is an example of this made right. I'd like to have more generic > plasmoids. Even better, I'd like to have an easy way to configure them. > > > > > > > Let's see the code. config.patch shows a way to load a config metadata file > and fill a designated plasmoid with the configuration data > (metadata.desktop). We search for a X-Plasma-ConfigApplet property that > defines the plasmoid to configure and load. Additional properties define the > plasmoid settings. This allows us, for example, to easily provide access to > any webservice without code duplication. > > > > > Diffs > ----- > > plasma/data/servicetypes/plasma-applet.desktop 8fabddb > plasma/pluginloader.cpp e57cac5 > > Diff: http://git.reviewboard.kde.org/r/101251/diff > > > Testing > ------- > > Loading of plasmoids works. > Configuration is not correctly being feed to plasmoids. > > > Thanks, > > David > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
