----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/#review2961 -----------------------------------------------------------
plasma/pluginloader.cpp <http://git.reviewboard.kde.org/r/101251/#comment2540> coding style: 'if (' not 'if(' same for all lines that follow in this patch. plasma/pluginloader.cpp <http://git.reviewboard.kde.org/r/101251/#comment2539> config does not need to cascade. you only need a KSimpleConfig here plasma/pluginloader.cpp <http://git.reviewboard.kde.org/r/101251/#comment2541> applet->config() probably does not return the actual config group, but a temporary group that gets migrated later. i assume this works (and that you have test it :). this would be overly easy to break, however. as a result, i'd like to see an automated test in kdelibs/plasma/tests/ that tests this mechanism, otherwise it will be far too easy for it to break accidentally leaving all widgets that use it non-operational. - Aaron J. On April 29, 2011, 1:09 a.m., David Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101251/ > ----------------------------------------------------------- > > (Updated April 29, 2011, 1:09 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > There is some code duplication in that some plasmoids share very much of > program logic but actually differ in just a setting. E.g. the recently made > ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon > plasmoid is an example of this made right. I'd like to have more generic > plasmoids. Even better, I'd like to have an easy way to configure them. > > > > > > > Let's see the code. config.patch shows a way to load a config metadata file > and fill a designated plasmoid with the configuration data > (metadata.desktop). We search for a X-Plasma-ConfigApplet property that > defines the plasmoid to configure and load. Additional properties define the > plasmoid settings. This allows us, for example, to easily provide access to > any webservice without code duplication. > > > > > Diffs > ----- > > plasma/data/servicetypes/plasma-applet.desktop 8fabddb > plasma/pluginloader.cpp e57cac5 > > Diff: http://git.reviewboard.kde.org/r/101251/diff > > > Testing > ------- > > Loading of plasmoids works. > > Testcase: Install these widgets: > http://kde-look.org/content/show.php/Label?content=99881 > http://kde-look.org/content/show.php?content=141270 > > Add configlabel to desktop. > > > Thanks, > > David > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
