> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently > > Shaun Reich wrote: > I think/hope you meant that the selection icon should be hidden when > double is *enabled*. i.e. singleclick is on. Since the selection icon is the > most useful when you can't click to select (single-click mode only). > > That said, the option has existed since forever in Dolphin, if we're > going to bring a feature over, we'd better bring the whole thing and not just > bits and pieces to make it inconsistent (as the patcher duly noted. > > Marco Martin wrote: > yes, selection icon enabled when double click is disabled. > > but honestly, i rather see it as a problem of dolphin if it lets > configure such a thing. > only thing that would make sense (since removing that from dolphin would > probably cause a revolution as the removal of anything) is to read that > setting from the dolphin configuration itself rather than the applet own one > > Shaun Reich wrote: > Well, given how stringent Peter is on settings, I'm sure he didn't add it > without quite some thought and good reasons ;) > > But yes, for unification's sake, it definitely makes the most sense to > make it as global as can be. Otherwise they have crap to configure in dolphin > and then every folderview they own. Plus it keeps it clean; good idea. > > Ignat Semenov wrote: > OK. So, are you fine with the implementation code? > > If yes, I will commit the backend part (ActionOverlay) separately? The > GUI bits may come in later. > > Please, give me a final decision on this. Do I maybe need to wait for > Aaron to approve this (a week, that is)?
OK, I will post a diff with automatic double-click detection soon. - Ignat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review9500 ----------------------------------------------------------- On Jan. 3, 2012, 1:03 p.m., Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103618/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2012, 1:03 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > This patch implements a proposal from the Netrunner project > (netrunner-os.com), a KUbuntu derivative, aimed at polishing the KDE desktop, > as part of my work for the project. > > This feature allows the user to hide the "+" selection marker in the > FolderView applet. It is absolutely symmetrical to the "Click to view folder" > feature. The code is similar as well. One thing I had to change is the button > hiding logic in ActionOverlay. The selection marker is positioned above the > folder peek button, so it needs a QGraphicsGridLayout::removeItem() / > ::addItem() instead of a QWidget::hide(), performed every time on the > entered() event. As the ::removeItem() has to be called only once, I had to > implement a public function that would toggle the button hiding / unhiding. > > Then, to be symmetrical, I changed the folder peek button hiding code to use > the same functions, with the same public interface in the ActionAoverlay > class. > > I hope the function addition is OK and does not violate neither incapsultion > nor the KDE class design principles. > > > Diffs > ----- > > plasma/applets/folderview/actionoverlay.h 056c83b > plasma/applets/folderview/actionoverlay.cpp 430e6dc > plasma/applets/folderview/folderview.h c8869b4 > plasma/applets/folderview/folderview.cpp d620a7d > plasma/applets/folderview/folderviewDisplayConfig.ui e7a5e46 > plasma/applets/folderview/iconview.h 677aa76 > plasma/applets/folderview/iconview.cpp abf775e > > Diff: http://git.reviewboard.kde.org/r/103618/diff/diff > > > Testing > ------- > > Works fine. > > The only problem is that following a recent Aaron's commit regarding > configChanged() / configAccepeted() in the FolderView applet circa 2 weeks > ago, the settings in this applet are applied only on Plasma restart and not > on the fly after hitting the Appy or Ok buttons. Aaron, please, have a look > into this. This happens with any settings, not onyl the ones I added. (My > settings code is absolutely identical to the "Click to view folder" settigns > code). > > > Thanks, > > Ignat Semenov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
