----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/ -----------------------------------------------------------
(Updated Jan. 3, 2012, 5:21 p.m.) Review request for Plasma, Aaron J. Seigo and Peter Penz. Changes ------- Added Peter Penz to the discussion. Peter, we have chosen to use the global single-click settings for enabling / disabling the selection marker in the FolderView applet, contrary to exposing a configuration UI, like it's currently done in Dolphin. We Plasma devs invite you to consider doing a similar change in Dolphin for the sake of consistency. Description ------- This patch implements a proposal from the Netrunner project (netrunner-os.com), a KUbuntu derivative, aimed at polishing the KDE desktop, as part of my work for the project. This feature allows the user to hide the "+" selection marker in the FolderView applet. It is absolutely symmetrical to the "Click to view folder" feature. The code is similar as well. One thing I had to change is the button hiding logic in ActionOverlay. The selection marker is positioned above the folder peek button, so it needs a QGraphicsGridLayout::removeItem() / ::addItem() instead of a QWidget::hide(), performed every time on the entered() event. As the ::removeItem() has to be called only once, I had to implement a public function that would toggle the button hiding / unhiding. Then, to be symmetrical, I changed the folder peek button hiding code to use the same functions, with the same public interface in the ActionAoverlay class. I hope the function addition is OK and does not violate neither incapsultion nor the KDE class design principles. Diffs ----- plasma/applets/folderview/actionoverlay.h 056c83b plasma/applets/folderview/actionoverlay.cpp 430e6dc plasma/applets/folderview/folderview.h c8869b4 plasma/applets/folderview/folderview.cpp d620a7d plasma/applets/folderview/iconview.h 677aa76 plasma/applets/folderview/iconview.cpp abf775e Diff: http://git.reviewboard.kde.org/r/103618/diff/diff Testing ------- Works fine. The only problem is that following a recent Aaron's commit regarding configChanged() / configAccepeted() in the FolderView applet circa 2 weeks ago, the settings in this applet are applied only on Plasma restart and not on the fly after hitting the Appy or Ok buttons. Aaron, please, have a look into this. This happens with any settings, not onyl the ones I added. (My settings code is absolutely identical to the "Click to view folder" settigns code). Thanks, Ignat Semenov
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
