> On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: > > applets/calculator/package/contents/ui/calculator.qml, line 231 > > <http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line231> > > > > I guess all the string values need to be wrapped in i18nc("C") .. > > Someone else would need to confirm this since i don't know for sure. This > > is for all the parts where you use a string. > > Romário Rios wrote: > Every string displayed to the user you mean. > > Anyway, is this necessary for the numbers?
Yes, the user visible ones. Don't know for the numbers. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21491 ----------------------------------------------------------- On Nov. 6, 2012, 11:36 p.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107001/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 11:36 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This diff replaces the C++ Calculator applet by its QMLfied version, which > seems to be feature-par with the latter. > > > Diffs > ----- > > CMakeLists.txt 732145c > calculator.h f7339be > calculator.cpp 6bc3ddc > package/contents/ui/calculator.qml PRE-CREATION > package/metadata.desktop PRE-CREATION > plasma-applet-calculator.desktop 0760729 > > Diff: http://git.reviewboard.kde.org/r/107001/diff/ > > > Testing > ------- > > Tested as both applet and popupapplet, with the Air theme and the Oxygen > theme. It seems to work fine. > > > Thanks, > > Romário Rios > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel