> On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: > > Your diff contains commented out changes to metadataupdater.cpp which I > > think you don't need. Please revert changes to that file and post a fresh > > diff. > > > > (Also, you even copied "(END)" which mostly happened while copy-pasting > > from the terminal, use "git diff > patchname.diff" which will save the > > exact diff to patchname.diff which you can then upload.)
sorry for that. But i have chnged some things in the metadataupdater.cpp to support my ubuntu version. So i cant change those. what should i do? - Rukshan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 ----------------------------------------------------------- On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116517/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 7:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Implement change volume on mouse wheel when top of the voulume icon. > > > Diffs > ----- > > mediaelements/mediacontroller/MediaController.qml 968c459 > > Diff: https://git.reviewboard.kde.org/r/116517/diff/ > > > Testing > ------- > > tested the function and not change the default controlling due to new changes. > > > Thanks, > > Rukshan Chathuranga > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
