----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51423 -----------------------------------------------------------
mediaelements/mediacontroller/MediaController.qml <https://git.reviewboard.kde.org/r/116517/#comment36211> This creates an empty space between the curMediaTime Label and volumeSlider as these items (Including the MouseEventListener) are in a Row {}. The right thing to do is to move the MouseEventListener inside the volumeButton and anchor.fill: parent mediaelements/mediacontroller/MediaController.qml <https://git.reviewboard.kde.org/r/116517/#comment36212> Please configure your editor to use 4 spaces instead of tabs. The next diff you upload should be spaces instead of tabs. For more, read http://techbase.kde.org/Policies/Kdelibs_Coding_Style - Shantanu Tushar On March 1, 2014, 11:32 a.m., Rukshan Chathuranga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116517/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 11:32 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Implement change volume on mouse wheel when top of the voulume icon. > > > Diffs > ----- > > mediaelements/mediacontroller/MediaController.qml 968c459 > > Diff: https://git.reviewboard.kde.org/r/116517/diff/ > > > Testing > ------- > > tested the function and not change the default controlling due to new changes. > > > Thanks, > > Rukshan Chathuranga > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
