> On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote:
> > Good thinking, and in fact this is the idea that first came to my mind.
> > But, as you would've noticed, the experience on clicking the button isn't
> > very natural now because you aren't really pressing the button.
> > Another (and better, imo) solution you can try is reverse the parenting
> > order of MouseEventListener and ToolButton (i.e. MouseEventListener {
> > ToolButton { } }). This way you will get both the interactions (click and
> > scroll) and will still feel natural.
>
> Rukshan Chathuranga wrote:
> Oh really. But i can't see any diffent or any unnatural behavior after
> this modification. i'm sorry, may be i can't see that small difference. But
> my suggestion is until we find the most appropriate way, we can use this
> modification as the fixed one.
>
>
> Shantanu Tushar wrote:
> Without the patch, the volume button reacts to your pushing and releasing
> the mouse button on the volume button. With the patch, it works even if you
> don't release the mouse button (that is one of the things), etc.
> As I said, all you need to do to fix this is to change the order of
> parenting. If you get any problems, let me know, in that case I can do it for
> you :)
ohhhh thanks Tushar, i will work on that and let you know any trouble if i got.
- Rukshan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51601
-----------------------------------------------------------
On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116517/
> -----------------------------------------------------------
>
> (Updated March 1, 2014, 3:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Implement change volume on mouse wheel when top of the voulume icon.
>
>
> Diffs
> -----
>
> mediaelements/mediacontroller/MediaController.qml 968c459
>
> Diff: https://git.reviewboard.kde.org/r/116517/diff/
>
>
> Testing
> -------
>
> tested the function and not change the default controlling due to new changes.
>
>
> Thanks,
>
> Rukshan Chathuranga
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
